Adds `force_pointing` kw to match_params

simonsobs / sotodlib

Simons Observatory: Time-Ordered Data processing library.

MIT License

16 stars 19 forks source link

Adds `force_pointing` kw to match_params #924

Closed jlashner closed 1 month ago

jlashner commented 3 months ago

New force_pointing match param that will make it so only detectors with pointing information are matched.
Removes the force_src_pointing param (which would force a match if pointing is provided) since this was always buggy and never had good results
Allows you to set resonator pointing from the ResSet.from_aman function.

jlashner commented 2 months ago

Alright, I added different pointing checks that depend on the det-type like you described above, and confirmed that it still works and that I still get good matches. Info on the new match solutions + plots are here: https://simonsobs.atlassian.net/wiki/x/RwC2JQ

I also changed the config option from force_pointing to enforce_pointing_reqs.

jlashner commented 2 months ago

Hi @mhasself, I think I addressed your feedback so this is ready for a re-review when you can!