G3thwp update template subtraction

simonsobs / sotodlib

Simons Observatory: Time-Ordered Data processing library.

MIT License

16 stars 19 forks source link

G3thwp update template subtraction #931

Open ykyohei opened 3 months ago

ykyohei commented 3 months ago

This PR will update the hwp_angles metadata

Improve template subtraction. Done
Improve robustness of hwp_angle solution against noise in encoder data. Done
Fix bug of filled_flag. WIP
Make new bad revolution flag. Done
Add data quality WIP?

Following are moved to separate PR.

Improve logging. Done
Fix nan problems. Done
- hwp_angle had nan in the observation that the hwp stopped in the middle of observations.

17-sugiyama commented 3 months ago

I've tested the code. Template subtraction looks nice but eval_offcentering fails for some reasons. Do we know that current eval_angle on master branch has a bug to add the template? (top panel, ver2) Your new template_subtraction successfully subtracts the template. (bottom panel, ver2) I would like to merge this PR as soon as possible!

ykyohei commented 3 months ago

If there is noise in encoder data, then the current "template_subtraction" could fail and subrtact template in a wrong way (add template). This PR is making the hwp_angle solution robust again issues caused by the noise in encoder data. Can you tell me the observation id you found this issue?