search

simonster / Reexport.jl

Julia macro for re-exporting one module from another
Other
161 stars 19 forks source link

Prepare to release version 1.0.0 #23

Closed ararslan closed 3 years ago

ararslan commented 4 years ago

Changes:

Since Reexport is such a stable package, it makes sense for it to declare itself to be at version 1.0. That way packages which depend on it can specify their version requirement as Reexport = "1" without needing to add a new 0.x version of Reexport to their [compat] every time one is released.

@simonster, can you add JuliaRegistrator and TagBot for this repository?

meggart commented 4 years ago

Bump, I would really love to see a 1.0 release

ararslan commented 4 years ago

Bump @simonster for the registration infrastructure. :pray:

ranocha commented 4 years ago

Bump, that would be really nice to have, @simonster

bkamins commented 3 years ago

Bump 😄. More and more packages that use this package reach 1.0 maturity so it would be great if Reexport.jl is also tagged 1.0.

johnnychen94 commented 3 years ago

Perhaps we could do a manual tag for this package? As it is small and stable, it seems okay to do manual maintenance, i.e., clean up the codes, make PR to general, tag and make a release here.

Probably use https://github.com/GunnarFarneback/LocalRegistry.jl to assist the process.

ararslan commented 3 years ago

So little changes in this package that I think it's okay for it to remain at its current minor version for the foreseeable future; there are unlikely to be any breaking changes anytime soon AFAICT. Releasing 1.0 is more of a longer-term convenience should further development happen. But now that Julia is at 1.0, changes to the AST that would break this package are unlikely.

meggart commented 3 years ago

Well at least I really need this commit https://github.com/simonster/Reexport.jl/commit/258a4088bb77ee4821bf2da1c73fd6e4897fd43c which is not tagged currently, so I have a copy of the macro in one of my packages. To me it does not matter if this is tagged 1.0 or 0.x, but tagging would be very nice.

ararslan commented 3 years ago

Ah, sorry, I had forgotten that there are currently untagged commits...

ararslan commented 3 years ago

Given that this PR has been open for over a year and has seen quite a bit of community support, I made an Executive Decisionâ„¢ to just merge this and proceed with the package registration steps manually. It's a bit error prone but worth the trouble.

nalimilan commented 3 years ago

Could you create a 1.0 tag? Looks like TagBot isn't properly set up or failed.

ararslan commented 3 years ago

Yep TagBot isn't enabled here. Done manually now, sorry for the delay.