search

simonster / Reexport.jl

Julia macro for re-exporting one module from another
Other
161 stars 19 forks source link

Add CI and TagBot workflows #26

Closed timholy closed 3 years ago

timholy commented 3 years ago

travis.org is going away and travis.com will not be free. Moreover, the 1.0 release didn't get a tag. This switches to GitHub Actions for both activities.

simonster needs to set up a DOCUMENTER_KEY. Instructions can be found at https://github.com/julia-actions/MassInstallAction.jl/blob/a7872f2837e68e37857d0a8ea5b57acb101d8c8b/demos/MaintenanceDec2020/maintenance.jl#L29-L41

timholy commented 3 years ago

Puzzling, but the workflow is running here: https://github.com/timholy/Reexport.jl/runs/1612316499

fingolfin commented 3 years ago

When you add a new workflow, it is only executed on your personal fork, not on the target repository -- this is for security reasons.

fingolfin commented 3 years ago

Someone should also update the badge in the README.

Oh, and I guess this PR closes #25 :-)

ararslan commented 3 years ago

simonster needs to set up a DOCUMENTER_KEY.

Seems unlikely to happen... :grimacing: This package doesn't use Documenter though, so is it really needed?

timholy commented 3 years ago

I'm no expert on these matters, but AFAIK TagBot needs some key for workflow-dispatch.

ararslan commented 3 years ago

Hmm, okay. I'm okay with continuing to make git tags manually, and since Pkg doesn't care about git tags, I think it's okay for now. If you agree then I'll just go ahead and merge.

timholy commented 3 years ago

Sounds good. Perhaps we could also consider getting @simonster to agree to transfer the repository, or to add you with admin privileges?

ararslan commented 3 years ago

That would definitely be ideal but no one has heard from him in quite some time, unfortunately.