search

simont77 / fakegato-history

Module to emulate Elgato Eve history
MIT License
168 stars 16 forks source link

Add Eve Room 2 Support #114

Closed sieren closed 3 years ago

sieren commented 3 years ago

Add support for Eve Room 2 using its characteristics and different data stream. The API accepts VOC in ug/m3, though the Eve app displays these values as ppb (ug/m3 * 4.57 = ppb).

See: https://github.com/simont77/fakegato-history/issues/107

Tested with homebridge-hue (See https://github.com/ebaauw/homebridge-hue/pull/1020)

IMG_040B73739D43-1 IMG_3492

simont77 commented 3 years ago

Thanks for this PR. At the moment I’m on holiday and cannot check it, nor publish on NPM. Could you update also the readme in the meantime?

sieren commented 3 years ago

@simont77 good call! Will add this.

sieren commented 3 years ago

@simont77 force pushed a README update to the initial commit.

sieren commented 3 years ago

Example running an Aqara TVOC Sensor via homebridge-hue:

IMG_3499 IMG_3498 IMG_3500

simont77 commented 3 years ago

Are you ok with this PR or you need more testing?

sieren commented 3 years ago

@simont77 it seems to look good now. I realised during long-term testing that VOC values need to be integers, not floats and the averaging by the timer would introduce floats, so I added a fix for that on tuesday specifically for VOC. also added documentation for https://github.com/simont77/fakegato-history/issues/107#issuecomment-913822887

sieren commented 3 years ago

Actually hold off, this is missing in the README.

sieren commented 3 years ago

Okay, we're good now 👍