search

simont77 / fakegato-history

Module to emulate Elgato Eve history
MIT License
167 stars 15 forks source link

Added TargetTemperature and ValvePosition to accessoryType 'custom'. #119

Closed banboobee closed 2 years ago

banboobee commented 2 years ago

Hi simont77 , Based on the discussions of #97, I Added TargetTemperature and ValvePosition to accessoryType 'custom', and confirmed that it works well with revised version of 'Homebridge Broadlink RM Pro'. The URL of the proved plug-in is https://github.com/banboobee/homebridge-broadlink-rm.git.

Its my pleasure that if these additions are integrated to your code base.

Thanks in advance.

simont77 commented 2 years ago

Thanks for this PR. Could you also update the readme accordingly?

banboobee commented 2 years ago

Thank you for prompt reply and sorry for missing the document revision.

I updated the README file.

Please let me know if something are wrong. I'm very new to github and this is my first PR.

Thanks in advance.

simont77 commented 2 years ago

Merged and published on npm

banboobee commented 2 years ago

I'm glad to hear that. Thank you very much.