Closed lint2015 closed 6 years ago
simont77
commented
6 years ago Did you check with Hesperus if all services and characteristics are visible to iOS? Unfortunately you are using a dynamic plugin, and I’m not familiar with that. Maybe @NorthernMan54 can help you.
NorthernMan54
commented
6 years ago I’m away from my computer for a few days, and can take a look when I’m back home.
On May 27, 2018, at 3:57 AM, simont77 notifications@github.com wrote:
Did you check with Hesperus if all services and characteristics are visible to iOS? Unfortunately you are using a dynamic plugin, and I’m not familiar with that. Maybe @NorthernMan54 can help you.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
lint2015
commented
6 years ago @simont77 I’ve just installed it and indeed the entire history service I created isn’t being seen there, whereas the weather history service is. It does look related to it not being assigned iids.
Thanks guys. When I get some more time I’ll try debugging with HAP-NodeJS, which seems to be responsible for iid assignments, too.
NorthernMan54
commented
6 years ago Just looking at this quickly, and I’m wondering if “Fakegato” is not seeing this as a platform accessory
In this line
this.historyService = new FakeGatoHistoryService("energy", this, {
storage:'fs',
minutes: 5
});When you pass “this”, it should be the accessory, and this “if" should trigger. If the “if” isn’t triggering you are passing the wrong object. Looking at the plugin structure, I’m thinking it could be “this.homebridgeAccessory"
https://github.com/simont77/fakegato-history/blob/fe7e5bc768aa538b7c5a569dfd1d63bf0ce0485a/fakegato-history.js#L443 https://github.com/simont77/fakegato-history/blob/fe7e5bc768aa538b7c5a569dfd1d63bf0ce0485a/fakegato-history.js#L443
PS Some pro-tips when your extending / working with someones’s plugin
1 - Fork their repository, and clone it directly into your development environment 2 - When you are asking for advice, check in your changes to GitHub, so people can just look at your GitHub and / or fork your changes to look at them ( Saves using dropbox etc ) 3 - When your done your changes, you can easily submit a pull request back to the original plugin author.
On May 27, 2018, at 7:31 PM, lint2015 notifications@github.com wrote:
@simont77 https://github.com/simont77 I’ve just installed it and indeed the entire history service I created isn’t being seen there, whereas the weather history service is. It does look related to it not being assigned iids.
Thanks guys. When I get some more time I’ll try debugging with HAP-NodeJS, which seems to be responsible for iid assignments too.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/simont77/fakegato-history/issues/55#issuecomment-392387882, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5CmF2jF6yXbh_QZPwKdnD4zHgKNk-0ks5t2zdfgaJpZM4UPJi3.
lint2015
commented
6 years ago @NorthernMan54 Thanks. I suspected I might've been passing the wrong object... I logged the 'this' object to check but the way the object was set up was incredibly unwieldy - over 1700 lines...
Reviewing the object again, it looks like the nests in the json output werent indented properly - which gave the illusion that the fakegatoHistoryService was created under the same object as the accessory's infoService and outletService. Your suggestion looks extremely promising.
Regarding the if statement, I had already logged where it was going and it was branching to the else as you suspect.
Thanks for your help! I'm not familiar with GitHub procedure but it's about time I read up on it and follow recommended procedures...
lint2015
commented
6 years ago Okay, I've got it working now! After changing the object being passed, the last hurdle was the accessory being programmed to remove any services it didn't recognise, which meant the history service was getting purged not long after being created.
Again, thanks for the help! I've started putting some of the code changes on GitHub as I clean them up.
Also, just a heads up, the library of Eve custom characteristics linked in the Wiki has been moved here: https://github.com/ebaauw/homebridge-lib/blob/master/lib/EveHomeKitTypes.js
NorthernMan54
commented
6 years ago Great news
On May 28, 2018, at 8:12 PM, lint2015 notifications@github.com wrote:
Okay, I've got it working now! After changing the object being passed, the last hurdle was the accessory was programmed to remove any services it didn't recognise, probably to get rid of cached services created by older versions.
Again, thanks for the help! I've started putting some of the code changes on GitHub as I clean them up.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
simont77
commented
6 years ago Also, just a heads up, the library of Eve custom characteristics linked in the Wiki has been moved here: https://github.com/ebaauw/homebridge-lib/blob/master/lib/EveHomeKitTypes.js
Thanks, updated!
I'm trying to implement energy consumption history into this plugin. It appears to be creating the fakeGatoHistoryService, adding entries, and writing entries to disk properly, but I still cannot see history in the Eve app.
I also have the homebridge-weather-station-extended plugin installed it's working fine. When the Eve app is refreshed, there will be activity in the log where fakegato-history sends new weather entries to the Eve app, but not so for the energy consumption history I'm trying to implement.
I've noticed nothing in the fakeGatoHistoryService is being assigned an iid, they all remain null and I suspect this is why it's not working, but I can't figure out why this is happening or how to fix it. Any pointers?
I've uploaded a copy of my code here, and this is a sample of the fakegatoHistoryService (iids bolded):
Cheers!