simontegg / hotdrink

Automatically exported from code.google.com/p/hotdrink
0 stars 0 forks source link

Overwriting user input #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There are cases where the most recently edited value should not be immune to 
change. A slider with user-defined min and max bounds is an example. Currently, 
if a derived value in the solution graph is the most recently edited value, it 
will not be overwritten during evaluation. This protection should be removed.

Original issue reported on code.google.com by jfreema...@gmail.com on 7 Feb 2011 at 5:13

GoogleCodeExporter commented 9 years ago
The new example "Enforced min-max" was created (in the examples branch) to 
document this issue.

Original comment by jfreema...@gmail.com on 16 Feb 2011 at 1:03

GoogleCodeExporter commented 9 years ago
It appears this behavior stems from the fact that self-loop inputs are not 
included in the inputs list for a method. Therefore, if one of the values to be 
output (i.e. one of the self-loop values) is edited, it will not show up as a 
relevant, changed input, and the method will not be executed.

Including self-loops in the input list may affect other portions of the library 
that look at the input list (like the solver) and lead to other bugs. However, 
we could keep a separate list of self-loop inputs that are inspected by the 
evaluator to fix this issue.

Original comment by jfreema...@gmail.com on 16 Feb 2011 at 2:28

GoogleCodeExporter commented 9 years ago

Original comment by jfreema...@gmail.com on 16 Feb 2011 at 7:56

GoogleCodeExporter commented 9 years ago
Fixed in examples branch 212f42b. It was always the case that values would be 
overwritten, but now values involved in self-loops will trigger their defining 
methods after being user-edited.

Original comment by jfreema...@gmail.com on 18 Feb 2011 at 5:29

GoogleCodeExporter commented 9 years ago
Added test in [test 774d4f6].

Original comment by jfreema...@gmail.com on 22 Jan 2012 at 6:22

GoogleCodeExporter commented 9 years ago

Original comment by jfreema...@gmail.com on 22 Jan 2012 at 6:23