search

simontelephonics / smsconnector

SMS Connector module for FreePBX 16 and 17
https://simon.tel/open-source/
GNU General Public License v3.0
37 stars 16 forks source link

Do the variables exist? #33

Closed vsc55 closed 6 months ago

vsc55 commented 6 months ago

Hi @billsimon,

I was looking at the latest updates of the module and I saw these two lines: https://github.com/simontelephonics/smsconnector/blob/c6ef6a5acb9c44225eb96af338de6dcff289de56/Smsconnector.class.php#L998 https://github.com/simontelephonics/smsconnector/blob/c6ef6a5acb9c44225eb96af338de6dcff289de56/Smsconnector.class.php#L1065

The $command and $process variabels are not declared in the startFreepbx and stopFreepbx functions. This is correct, does it not generate an error?

Greetings and thanks for the module.

billsimon commented 6 months ago

Thank you for your code review. This code is going away in the next release because I found a beter way to do this that does not require the daemon process.