simontelephonics / smsconnector

SMS Connector module for FreePBX 16 and 17
https://simon.tel/open-source/
GNU General Public License v3.0
43 stars 16 forks source link

Update layout, parse args and other things #4

Closed vsc55 closed 1 year ago

vsc55 commented 1 year ago

Hi @billsimon,

I have made some small updates to the module to see what you think.

imagen

imagen

imagen

billsimon commented 1 year ago

Hi,

There are some nice updates here and I really appreciate the contribution.

Unfortunately the sending function no longer works. Can you go back and review the logic? The problem seems to be with Smsconnector->getProvider() method but I have not been able to successfully debug.

vsc55 commented 1 year ago

Hi @billsimon, I have already found the error. As soon as I have it ready I update the PR.

vsc55 commented 1 year ago

Hi @billsimon, With the latest fix it should now work without problems.

billsimon commented 1 year ago

I merged your work to the master branch. Thank you! I am going to do a little more work before merging to release branch.