search

simontelephonics / smsconnector

SMS Connector module for FreePBX 16 and 17
https://simon.tel/open-source/
GNU General Public License v3.0
43 stars 16 forks source link

Adding bandwidth and updating readme #46

Closed MatthewLJensen closed 3 months ago

MatthewLJensen commented 7 months ago

I've implemented the SMS interface for Bandwidth.

It supports 1 on 1 sms and mms chats. Let me know if there is a way to support group messaging, I just did not see it in the other providers.

There is an optional setting within bandwidth to supply a username and password on callback messages. This authentication is also supported within this interface via the optional 'callback_user_id' and 'callback_password' fields.

This interface does not currently listen for the callbacks that bandwidth supplies that indicate the status of a sent message. Those statuses include 'sending', 'delivered', and 'failed'. So, it is recommended that these are disabled on Bandwidth's side (via a checkbox for each type) until they are supported. Thus a message is 'delivered' when it is received at the carrier.

billsimon commented 7 months ago

Thanks for this contribution, @MatthewLJensen ! I'll review it soon.

MatthewLJensen commented 4 months ago

Sorry for the massive delay. Ended up being out of the country for a while and didn't prioritize this.

I wasn't sure the best way to update the i18n files, or if it was necessary, so let me know if the strings I'm using need to be added there manually.

vsc55 commented 4 months ago

Sorry for the massive delay. Ended up being out of the country for a while and didn't prioritize this.

I wasn't sure the best way to update the i18n files, or if it was necessary, so let me know if the strings I'm using need to be added there manually.

Hi @MatthewLJensen, Everything correct, it looks good. There is no need to update the i18n files since the native language is English. When they merge the pr, I will add the Spanish translation and then update the i18n files.

billsimon commented 3 months ago

Merged to master; will be released shortly