[ng-core] Private identifiers are only available when targeting ECMAScript 2015 and higher.

[DmitryEfimenko]

Our project at work requires using target ES5. When using this target, the compilation throws an error:

ERROR in node_modules/@s-libs/ng-core/lib/directive-superclass.d.ts:42:5 - error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

I think this error is due to the usage like here

Can we change these to private keyword? I know that using # is more secure, but I don't think it really makes a difference for this library.

Update: I have tested my assumption in a local project and can confirm that making private fields use keyword private instead of # in the following two places fixes the issue:

• https://github.com/simontonsoftware/s-libs/blob/master/projects/ng-core/src/lib/directive-superclass.ts#L63
• https://github.com/simontonsoftware/s-libs/blob/master/projects/ng-core/src/lib/injectable-superclass.ts#L20

[ersimont]

Dmitry tells me this is no longer a need! 🎉