search

simontonsoftware / s-libs

A collection of libraries for any of javascript, rxjs, or angular.
MIT License
43 stars 5 forks source link

[ng-dev] Make sure `AngularContext.current` is always cleaned up #98

Closed ersimont closed 1 year ago

ersimont commented 1 year ago

If a context throws an error during cleanup, it can leave .current defined and cause all remaining tests to fail.

ersimont commented 1 year ago

An old TODO in ComponentContext.constructor:

    // TODO: once cleanup of contexts is not so touchy, move this below super() and use shortcut `private` declarations on constructor params