simonv3 / quick-survey

A tool for quick surveys, try it out. (No longer maintained).
https://apps.sandstorm.io/app/wupmzqk4872vgsye9t9x5dmrdw17mad97dk21jvcm2ph4jataze0
MIT License
116 stars 49 forks source link

Is there a new maintainer? #71

Open qirtaiba opened 5 years ago

qirtaiba commented 5 years ago

There are a bunch of forks of this project, but I'm not sure if any of them is working on fixing bugs like #54. I might be interested in becoming the new maintainer if nobody else is going to do that? These don't seem like super complex bugs to fix, or to pay someone a bug bounty to fix.

simonv3 commented 5 years ago

There's no new maintainer @qirtaiba and you'd be more than welcome to take that on. Let me know if you're interested and I can add you as a collaborator!

qirtaiba commented 5 years ago

Sure, thanks.

troyjfarrell commented 5 years ago

@simonv3 I am interested in maintaining quick-survey.

I looked at this last night. It seems that it's going to take some work on the Sandstorm side of things before we can make a release. Are you willing to work with me to make a new release?

simonv3 commented 5 years ago

@troyjfarrell I am, though my availability is pretty limited. Ideally there'll be a way to transfer that ability completely to you.

troyjfarrell commented 5 years ago

We can do that. I'll send a message to sandstorm-dev to see what the proper procedure is. (I recall reading something about me generating signing keys and the Sandstorm devs adding some code to Sandstorm, so it expects the new keys.)

ocdtrekkie commented 5 years ago

There are two ways to handle it. Either Simon can extract the app signing key for Quick Survey from his Sandstorm keyring and give it to you, so you can sign the app with no changes to Sandstorm, or you can release it under a new appId, and Kenton can add a replacement key entry into Sandstorm so that it will treat it as an update to the original app. Either way, you should probably change the author metadata, so it uses your name instead of his, but that's separate from the key that signs the app.

We can definitely help you through this process if you get the app updated and need any help publishing the updated version.

(I am currently the person who pushes the approval button on app updates.)

ocdtrekkie commented 5 years ago

@simonv3 Do you still have your app signing key? (It would likely be in a file in a .sandstorm folder of your home directory, in a file called sandstorm-keyring.)

If replacing the appId is necessary, @troyjfarrell may find this file pretty self-explanatory (or self-documenting, I guess) on what's involved: https://github.com/sandstorm-io/sandstorm/blob/master/src/sandstorm/appid-replacements.capnp

(Apparently, according to that file, you actually don't change the appId in the pkgdef when you rekey it, which I didn't know.)

troyjfarrell commented 5 years ago

I’ll get to work on a new release. (I’d like to update the dependencies.)

simonv3 commented 5 years ago

@ocdtrekkie I'm fairly sure I don't have the key anymore. I've gotten a new computer recently and that didn't make it across, sorry all :(

troyjfarrell commented 5 years ago

Thanks for the link. I don't mind going through the key replacement process.

It looks like we'll have to play some identity games, presumable to verify that Simon is still the same Simon who is willing to hand over maintainership:

# 4. PGP-sign your git commit using the `-S` flag, using the same PGP key you used to sign older
#    versions of your app as published to the app market. (If you can't do this, we'll need to
#    verify your identity in some other way.)

It's good timing. I've been wanting to generate a new PGP key for a while. I'll do that as part of this process.

ocdtrekkie commented 5 years ago

We can check with @kentonv about any verification that's required. Presumably @simonv3 still has his Keybase account, which is how he verifies his ownership of the app, and could sign a statement with that of his intent to transfer it or whatever. I'm not too worried.

kentonv commented 5 years ago

I'm OK with simon just approving the PR to appid-replacements.capnp.

troyjfarrell commented 5 years ago

Sounds good. I'm working on automating the build process. I suspect that I'll be ready to spin a new release around the beginning of April.

ocdtrekkie commented 4 years ago

@troyjfarrell Stumbling around and figured I'd ask if you were still interested in this, as we are working on https://sandstorm.io/news/2020-02-03-reviving-sandstorm and hence interested in reaching out to people contributing to Sandstorm and/or Sandstorm apps.