search

simonw / big-local-datasette

Publishing a Datasette of open projects from biglocalnews.org
https://biglocal.datasettes.com/
2 stars 0 forks source link

Only deploy on pushes to master, not on branches or pull requests #17

Closed simonw closed 4 years ago

simonw commented 4 years ago

If I'm going to open this repo I need to make sure pull requests don't cause a deploy.

https://github.com/simonw/big-local-datasette/blob/c12b82f436bb92a45f11760711f58b488759e050/.github/workflows/deploy.yml#L1-L6

simonw commented 4 years ago

I don't think I have to do anything for this, because secrets are only exposed to the master branch. I'll run a test now and see.

simonw commented 4 years ago

Huh apparently pushes to branches DO trigger deploys, with secrets intact! https://github.com/simonw/big-local-datasette/runs/581817348?check_suite_focus=true

I need to fix this then.