search

simonw / csv-diff

Python CLI tool and library for diffing CSV and JSON files
Apache License 2.0
295 stars 48 forks source link

No key precised case #5

Closed MainHanzo closed 4 years ago

MainHanzo commented 4 years ago

with the pytest for no key precised case passed :)

simonw commented 4 years ago

Oops, I didn't mean to close this - it closed automatically because I deleted the master branch.

simonw commented 4 years ago

Looks like I can still apply this using:

curl 'https://patch-diff.githubusercontent.com/raw/simonw/csv-diff/pull/5.diff' | git apply
simonw commented 4 years ago

I manually landed this fix in https://github.com/simonw/csv-diff/commit/09409e320910a13e444a95879ff326b7ce4c1624

I committed this patch (with a small change) using:

git commit -a --author "MainHanzo <...@gmail.com>" -m "Fix for error with no key provided, closes #3"