search

simonw / datasette-cluster-map

Datasette plugin that shows a map for any data with latitude/longitude columns
Apache License 2.0
87 stars 16 forks source link

Use new datasette.urls.static_plugins() method #22

Closed simonw closed 3 years ago

simonw commented 4 years ago

Refs https://github.com/simonw/datasette/issues/1033 - this will ensure the plugin works with base_url configuration option.

Relevant code: https://github.com/simonw/datasette-cluster-map/blob/be66a0b198527c6f2cfd5ae5dad9e2580f2891c7/datasette_cluster_map/__init__.py#L46

simonw commented 4 years ago

Blocked awaiting Datasette release containing that method.

simonw commented 3 years ago

This works already! It turns out Datasette handles that here: https://github.com/simonw/datasette/blob/25c2933667680db045851b2cedcf4666d737d352/datasette/app.py#L881-L883

I'll add a test and close this.