Refactor code to support different sources

simonw / datasette-media

Datasette plugin for serving media based on a SQL query

Apache License 2.0

19 stars 1 forks source link

Refactor code to support different sources #18

Closed simonw closed 4 years ago

simonw commented 4 years ago

Needed for #4, #6 and #14. The code is a bit of a mess - it needs to be refactored to support proxying from URLs, loading from database and other ways of specifying transforms.

simonw commented 4 years ago

Things it needs to be able to do:

Load image bytes from different sources - URLs (#4), filesystem, SQLite BLOBs (#14)
Apply transformations based on different configuration sources
- Columns that come back from the query
- ?w= and ?h= etc if enable_transform plugin setting is on #6

simonw commented 4 years ago

Transformations will still take place in a thread pool. Content loading is expected to happen via asyncio (or from the Datasette SQLite connection thread pool, which is also awaited).

simonw commented 4 years ago

I did just enough of this in #15 to close this issue.