simonw / db-to-sqlite

CLI tool for exporting tables or queries from any SQL database to a SQLite file
Apache License 2.0
370 stars 29 forks source link

Ryancheley patch 1 document updates #37

Closed ryancheley closed 1 year ago

ryancheley commented 3 years ago

@simonw documentation update to include examples for MS SQL

There may be a better way to show it and explain how it should be done, but I'm at a loss. The connection string for MS SQL with SQL Alchemy are just messy.

I also added headers to the connection string examples to separate them out and make it more clear which example went with which type of SQL.

simonw commented 3 years ago

This looks great!

The place you updated in the README is actually intended as a copy of the output of db-to-sqlite--help

I think this information would work better as a Markdown section in the README itself, similar to the "Using db-to-sqlite with PostgreSQL schemas" section.

ryancheley commented 3 years ago

Doh! 🤦🏻‍♂️

I’ll make an update to move it to its own section 😄

ryancheley commented 3 years ago

@simonw I made the updates to the documentation to have the MSSQL section separate based on your recommendation to use the "Using db-to-sqlite with PostgreSQL schemas" section.

simonw commented 1 year ago

I should have landed this a year ago! Thanks.

ryancheley commented 1 year ago

Thanks for getting this merged @simonw. Better late than never 😁