search

simonw / django-sql-dashboard

Django app for building dashboards using raw SQL queries
https://django-sql-dashboard.datasette.io/
Apache License 2.0
437 stars 37 forks source link

/dashboard/?edit=slug as opposed to /dashboard/slug/ #25

Closed simonw closed 3 years ago

simonw commented 3 years ago

I think /dashboard/slug/ should always be read-only. It can provide a link to /dashboard/?edit=slug(visible only to users with the right permissions) that provides the edit interface.

This will also help deal with the problem that the new Markdown and HTML widgets encourage dashboard SQL queries long enough that they might run into query string length restrictions. Those widgets are mainly intended to work with saved dashboards, where the edit would take place entirely via POST requests with much less restrictive size limits.

simonw commented 3 years ago

The widget custom templates will need to get better at handling the read-only case - maybe I could refactor them to use inheritance from a base template to help support this.

simonw commented 3 years ago

This is replaced by #44