Interface for creating and editing dashboards

simonw / django-sql-dashboard

Django app for building dashboards using raw SQL queries

https://django-sql-dashboard.datasette.io/

Apache License 2.0

437 stars 37 forks source link

Interface for creating and editing dashboards #44

Closed simonw closed 3 years ago

simonw commented 3 years ago

This is currently only possible in the Django Admin. This will also implement edit permissions, taking over from #27.

Still todo:

[x] Form to save a dashboard as a saved dashboard
[x] If dashboard reloads with form errors, scroll down to the form
[x] "Edit dashboard" link that links to the Django admin
[x] Custom Django admin code to respect edit policies
[x] Saved dashboard pages should show their visibility and edit policies

simonw commented 3 years ago

I'm going to put this interface at at /dashboard/<slug>/edit/

Creating dashboards will start with a button on /dashboard/ - which will redirect the user to the new /dashboard/<slug>/edit/ page for further changes.

simonw commented 3 years ago

For the first non-alpha release I'm going to link to the Django admin interface for edit.

simonw commented 3 years ago

This means I need to write custom admin permission logic that takes the edit permissions and groups into account.

simonw commented 3 years ago

I'm going to allow super-users to reassign ownership of dashboards - but regular users will not be able to do that, even if they own the dashboard.

simonw commented 3 years ago

Spotted an edge-case: if a user isn't staff they will not be able to access the edit interface, no matter what the edit policy is.

simonw commented 3 years ago

That test failure turned out to be a Django version problem! Upgrading to the latest Django in my dev environment gave me the ability to replicate the bug.