Turn [count] into a cog action menu item, add more

simonw / django-sql-dashboard

Django app for building dashboards using raw SQL queries

https://django-sql-dashboard.datasette.io/

Apache License 2.0

437 stars 37 forks source link

Turn [count] into a cog action menu item, add more #57

Closed simonw closed 3 years ago

simonw commented 3 years ago

Borrow the cog action menu design from Datasette. Actions can include:

Count values (the existing "count" link)
Sum / Avg / etc (for columns that are numbers)
Show not-null values

MoralCode commented 3 years ago

sort by ascending/descending might be useful to add to a menu like this as well

simonw commented 3 years ago

Yes, that's a great idea.

simonw commented 3 years ago

Here's what I implemented to start with:

cog

MoralCode commented 3 years ago

small nitpick: a settings icon may not be the most correct thing to use here and something that looks more like a filter or funnel may be a better choice to make the UI super clear

simonw commented 3 years ago

I'm using the same icon I used for Datasette, see https://github.com/simonw/datasette/issues/981#issuecomment-701664306.

I thought about using a filter/funnel icon but those to me imply tools for narrowing down the selection, which isn't what's happening here. I also tried using a ▼ icon but that looked too much like it was a "sort descending" indicator.

MoralCode commented 3 years ago

could a "three dots" or another hamburger menu type icon work?