simonw / llm-replicate

LLM plugin for models hosted on Replicate
Apache License 2.0
58 stars 6 forks source link

Add licence files for both this project and the vendored replicate #10

Closed tomviner closed 1 year ago

tomviner commented 1 year ago

Firstly for people to fork this plugin, you should add a licence. No doubt you intended one, but didn't remember yet.

Secondly, for the vendored replicate code, you should probably follow the the pip Vendoring Policy rule:

Vendored libraries MUST be accompanied with LICENSE files.

e.g. pip just puts the licence file along with the copied python files. See examples here

replicate uses the Apache License 2.0 which requires:

simonw commented 1 year ago

Good catch! Yes that was a mistake on my part (and I honestly forgot to do that for vendored code, I won't make that mistake in the future).

The good news is they shipped my fix so I can un-vendor that library now!

simonw commented 1 year ago

Added that Apache license file. I already had that marked in metadata here:

https://github.com/simonw/llm-replicate/blob/d1e6abe3c9aee2f29701687209427b9d42c2bd0f/pyproject.toml#L7