Closed simonw closed 4 years ago
Ditto for the debug output I just added running in the Action: https://github.com/simonw/museums/runs/596727459
Created:
{
"1": "2020-04-17T14:50:40-07:00",
"2": "2020-04-17T14:50:40-07:00",
"3": "2020-04-17T14:50:40-07:00",
"4": "2020-04-17T14:50:40-07:00",
"5": "2020-04-17T14:50:40-07:00",
Theory: could GitHub Actions be defaulting to a shallow checkout which means my annotate_timestamps.py
script can't see the full commit history?
Yes that's what's happening! https://github.com/actions/checkout says:
Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set
fetch-depth
to fetch more history.
Looks like I need fetch-depth: 0
.
That fixed it: https://github.com/simonw/museums/runs/596738949
Created:
{
"1": "2019-10-23T21:32:12-07:00",
"2": "2019-10-23T21:32:12-07:00",
"3": "2019-10-23T21:32:12-07:00",
"4": "2019-10-23T21:32:12-07:00",
"5": "2019-10-23T21:32:12-07:00",
"6": "2019-10-23T21:32:12-07:00",
"7": "2019-10-23T21:32:12-07:00",
"8": "2019-10-23T21:32:12-07:00",
"9": "2019-10-23T21:32:12-07:00",
https://www.niche-museums.com/ now shows the correct dates again.
https://twitter.com/kevinmarks/status/1251260017241731074