search

simonw / shot-scraper

A command-line utility for taking automated screenshots of websites
https://shot-scraper.datasette.io
Apache License 2.0
1.67k stars 73 forks source link

Make --timeout option consistent across all commands (including javascript) #118

Open beetleb opened 1 year ago

beetleb commented 1 year ago

Currently the javascript command doesn't support a timeout option.

(Wider context: I'm trying to use Readability as you described here).

simonw commented 6 months ago

Huh, right now the sub-commands shot and multi and accessibility have the --timeout option but javascript and html and pdf do not.

simonw commented 6 months ago

It's used like this: https://github.com/simonw/shot-scraper/blob/0268b0ccdb42e08738d840bb77484f2e60cdbd7f/shot_scraper/cli.py#L432-L434

So it needs to be passed like this:

https://github.com/simonw/shot-scraper/blob/0268b0ccdb42e08738d840bb77484f2e60cdbd7f/shot_scraper/cli.py#L520-L532