simonw / shot-scraper

A command-line utility for taking automated screenshots of websites
https://shot-scraper.datasette.io
Apache License 2.0
1.67k stars 73 forks source link

fix 'helpful' en-dashing in headings #81

Closed nedbat closed 2 years ago

nedbat commented 2 years ago

The headings get double-hyphens turned into en-dashes:

image

I'm not sure if this fixes it (I haven't used .md in Sphinx before), but it might?

nedbat commented 2 years ago

Helpfully, readthedocs built the pull request. Unhelpfully, the en-dashes are still there :(

nedbat commented 2 years ago

With backticks, the headers are formatted as code, which arguably is more correct, but also a little odd in a header:

image
simonw commented 2 years ago

https://shot-scraper--81.org.readthedocs.build/en/81/ shows a preview.

https://shot-scraper--81.org.readthedocs.build/en/81/installation.html#shot-scraper-shot-help

image

Compared to https://shot-scraper.datasette.io/en/stable/installation.html#shot-scraper-shot-help which exhibits the bug:

image
simonw commented 2 years ago

Thanks for this!