Fix test to pass `pytest -Werror`

[lbellomo]

Refs https://github.com/simonw/sqlite-utils/issues/541

Still TODO:

• [x] Fix tests/test_cli.py::test_upsert_analyze
• [x] Fix tests/test_cli_memory.py::test_memory_csv
• [x] Fix tests/test_cli_memory.py::test_memory_tsv
• [x] Fix tests/test_cli_memory.py::test_memory_dump
• [x] Fix tests/test_cli_memory.py::test_memory_two_files_with_same_stem
• [x] Fix tests/test_insert_files.py::test_insert_files
• [ ] Fix tests/test_recipes.py::test_dateparse_errors

---

📚 Documentation preview 📚: https://sqlite-utils--623.org.readthedocs.build/en/623/

[lbellomo]

The first case is not the test you mark, but the previous test_upsert_pk_required. When you run the upsert "click" opens the file first but as it then gives the error "Error: Missing option '--pk" it doesn't close it correctly.

https://github.com/simonw/sqlite-utils/blob/1d050dcdc7c8099108abd2987932a3d8d7bf55aa/sqlite_utils/cli.py#L868

The solution is to pass lazy=True to the click.File so that it does not open it until it is necessary.

[lbellomo]

It seems that in test_memory_csv only for when use_stdin=False the io.TextIOWrapper on line 297 is not closed correctly.

https://github.com/simonw/sqlite-utils/blob/1d050dcdc7c8099108abd2987932a3d8d7bf55aa/sqlite_utils/utils.py#L295-L302

The only way I can think of is to pass the buffer to _extra_key_strategy and close it once the generator is finished, but surely there must be a nicer way.

[lbellomo]

Similar to the first case, it is not test_memory_dump but test_memory_csv_encoding the previous test that is the culprit, and also only when use_stdin=False.

It seems that when the enconding is wrong it raises a UnicodeDecodeError error when it tries to iterate over the generator from rows_from_file and that's why it doesn't reach the end to close the fp file.

https://github.com/simonw/sqlite-utils/blob/1d050dcdc7c8099108abd2987932a3d8d7bf55aa/sqlite_utils/cli.py#L1949-L1968

The only thing that I can think of is to catch the error, close the file and raise it again.

[lbellomo]

test_insert_files.py is a deprecation warning. datetime.utcfromtimestamp is replaced by datetime.fromtimestamp in py3.12, I pass the timezone to make sure it is utc (otherwise it grabs the local one) and stripe the timezone to be the same as it was before.