search

simonwalz / screen-save

A tool to make screen sessions persistent = survive system reboot.
MIT License
25 stars 4 forks source link

Provide a debian packaging #10

Open camlafit opened 2 months ago

camlafit commented 2 months ago

Hello

It's very nice :) I've just adopted it and it's very nice. Could be nice to provide a debian packaging to deploy it with an easiest way. PR will be provide in next day.

simonwalz commented 2 months ago

Hi

Nice initiative!

Are you adding a Github Workflow to create the debian package or what is your plan?

Would you consider adding a check with shellcheck as a prerequisite?

I could see us later doing some integration testing based on docker containers.

Kind regards Simon

camlafit commented 2 months ago

Hi

I don't use github workflow but looks possible I do it yet through travis service on other project ( have a look to https://github.com/AlternC/deb-builder/)

About shellcheck I think could be nice to have it as prerequisite but I've tried to reduce patch size and use it only when is required by each PR.

I think look possible :

simonwalz commented 1 month ago

I agree with the separate PR for shellcheck. I created #15.

I will research (and maybe try) if it makes sense to build Debian packages in Github workflows.

simonwalz commented 1 month ago

It looks like it works with Github workflows. See https://github.com/simonwalz/screen-save/releases/tag/v1.2.6

I don't have much experience with deb packages. Is the deb package OK for you?

camlafit commented 1 month ago

Hello

Looks nice. I see some missing things as cron , changelog, ... but normally easy to patch. Then looks installable but not yet efficient :) Lintian return also some improvements easy to change.

I could check and see to propose workflow update. Doesn't look a big deal.

simonwalz commented 3 weeks ago

I have seen your progress and I like the idea with the systemd units and timer.

I would suggest, that we create one systemd unit/timer, that does the following:

I think every 30 minutes is enough because normally the sessions are saved on stop. So the timers are only needed if the system crashes. For this to work as intended, the unit must be the last to start and the first to stop.

A second suggestion is, that this unit is not loaded per default, so that users can choose to use the tool manually or activate the unit.

camlafit commented 3 weeks ago

Hello

I think I've found correct approach to build both way - sysv and systemd. But following my systemd understood , we need two services/times : one to restore and a second to save. Actually I don't see how to propose an unique unit to manage this two actions.

About period, I've set 5' without specific reason :) we can provide longest period without problem.