search

simonwep / pickr

🎨 Flat, simple, multi-themed, responsive and hackable Color-Picker library. No dependencies, no jQuery. Compatible with all CSS Frameworks e.g. Bootstrap, Materialize. Supports alpha channel, rgba, hsla, hsva and more!
https://simonwep.github.io/pickr
MIT License
4.29k stars 287 forks source link

When you click on the Clear button, the X overlay is not visible #283

Closed vkurko closed 3 years ago

vkurko commented 3 years ago

What is the current behavior?

When you click on the Clear button, the X overlay is not visible.

Please provide the steps to reproduce and create a JSFiddle.

  1. Open https://simonwep.github.io/pickr/
  2. Click on the color button to show the color picker
  3. Click Clear button

What is the expected behavior?

The color button gets transparent and a X overlay is added to indicate that there's no color selected.

Your environment:

Version (see Pickr.version): 1.8.1
Used bundle (es5 or normal one): es5
Used theme (default is classic): classic
Browser-version: Chrome 89.0.4389.114
Operating-system:  Ubuntu 20.04
vkurko commented 3 years ago

It looks like the X overlay was broken in this commit - not all places in the code were replaced with css variables.

For the same reason, the comparison option no longer works.

simonwep commented 3 years ago

Okay, related to #286

vkurko commented 3 years ago

@Simonwep thank you for fixing the issue. Will you publish v1.8.2 to npm? It is still 1.8.1 there.