search

simonwep / pickr

🎨 Flat, simple, multi-themed, responsive and hackable Color-Picker library. No dependencies, no jQuery. Compatible with all CSS Frameworks e.g. Bootstrap, Materialize. Supports alpha channel, rgba, hsla, hsva and more!
https://simonwep.github.io/pickr
MIT License
4.29k stars 287 forks source link

added workaround for some old androids with weird JS versions #294

Closed Funkelfetisch closed 2 years ago

Funkelfetisch commented 3 years ago

forgot to send in this PR while it was recent.

This fixes errors with some Androids misinterpreting the datatype of a field.

simonwep commented 3 years ago

What do you mean by "weird JS versions"? I generally do not intent to make any changes for specific JS engines which operate alongside the official ECMA specification...

Funkelfetisch commented 3 years ago

you don't "define" that variable as string, therefore some string functions don't work on a Oneplus 9t and Galaxy S..6?, if I remember correctly. it's just a small workaround that will save somebody a lot of brainfuck, I don't understand why you wouldn't merge that. But OK.

simonwep commented 3 years ago

You don't "define" any types in vanilla javascript either... if it isn't "something with a match function" at runtime it'll result in an runtime error. Could you tell me what JS engines are used in your case? It obviously isn't any of the mainstream engines such as the V8, SpiderMonkey, Webkit or even Gecko... I just want to get the "some JS versions" part as there normally is just a single one, the one specified by ECMA... all the other ones are not ECMAScript, don't follow their specification and just won't work in this case. It's a weird comment to have in your code-base if you're not targeting any extreme legacy systems.

simonwep commented 2 years ago

Closing because of inactivity.