simonwistow / Module-Pluggable

Automatically give your Perl module the ability to have plugins
http://search.cpan.org/dist/Module-Pluggable/
17 stars 16 forks source link

changed behavior of perl CORE (File::Find 1.39 - e.g. perl >= 5.34) on Windows #24

Open thockar opened 2 years ago

thockar commented 2 years ago

Callers of Module::Pluggable may fail with perl 5.34 on Windows (for example Perl::Critic - but possibly some more modules and tests). This is caused by the (undocumented) changed default behavior of File::Find 1.39 on MSWin32.

The following changes to Module::Pluggable::Object will force the old behavior of File::Find, if not otherwise told

Object.pm ....

default whether to follow symlinks

best regards Thomas

blues1875 commented 2 years ago

I just hit the same problem building perl 5.36 using the Strawberry Perl 5.32 toolchain. This fix also worked for me. Thanks Thomas.

sisyphus commented 2 years ago

As of perl-5.37.3 this issue has been addressed by https://github.com/Perl/perl5/pull/20008 and no patching of Module::Pluggable is required.