Convert to EUMM - Githubissues

moto-timo commented 9 years ago

I have packaged your module for OpenEmbedded/Yocto Project [1], which has moved to Perl 5.22 and no longer supports Module::Build (which has been deprecated since Perl 5.19). This module will be blacklisted next week without this change.

[1] http://git.openembedded.org/meta-openembedded/tree/meta-perl/recipes-perl/libmodule/libmodule-pluggable-perl_5.1.bb

simonwistow commented 9 years ago

Hi Tim - I actually used bits of your pull request and also this one simonwistow/Module-Pluggable#8

Into this branch

Can you check to see my branch works for you and I'll merge and deploy.

simonwistow commented 9 years ago

Also: because of another branch I had to add in support for an optional module.

It's been a while since I've used EUMM so I'm not sure if I've done it right. If you could double check that I'd be very grateful.

moto-timo commented 9 years ago

Still need the INSTALL update... (.\Build -> make). More later as I test it. Funny that I didn't notice Karen's PR! Thank you, Karen :)

karenetheridge commented 9 years ago

I've rebased the commits from master into this PR and force-pushed -- try git diff fb69fef96 d82f40f2e3:

I fixed the warnings with qw(), to enable use warnings
FindBin is not needed now, as this module won't be installed via PERL_CORE anymore
for authors, a fairly recent version of EUMM is required to ensure that metadata is generated properly for the uploaded distribution

I missed the INSTALL change -- good catch, Tim!) -- so I brought in that bit from PR #9.

I noticed you added an optional_features option for Module::Runtime. That's not the parallel to recommends in Module::Build, but there's no harm in including it, and some cpan clients do understand it now, so it can add value on top of a recommends prereq, so I added that from your commit.

simonwistow commented 9 years ago

Released to CPAN as version 5.2 .

Thanks for all your help!

simonwistow / Module-Pluggable

Convert to EUMM #9