Closed defvs closed 1 month ago
Name | Link |
---|---|
Latest commit | ee6d79ab1cd3cc3542add1d5447e50501a2083a8 |
Latest deploy log | https://app.netlify.com/sites/eavesdropfm/deploys/667dad7696be670008426b36 |
Deploy Preview | https://deploy-preview-199--eavesdropfm.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Turns out ListenBrainz does not yet support reading from the MBIDs sent in the JSON. Weird of them... I'll open a ticket tomorrow. I've double checked and the payload sent by Eavesdropfm is correct, so this can probably be merged without consequence, so that whenever it is fixed on LB side, it will works.
In any case - this won't really do anything on LB side until https://tickets.metabrainz.org/browse/LB-1330 is resolved.
I've started another branch, to resolve the track_mbid into release_mbid and recording_mbid because as I said earlier, LB does not yet use track_mbid for matching.
https://github.com/defvs/eavesdrop.fm/tree/track-mbid-resolving if you want to have a look...
Just tested everything now and I can see the track_mbid
being properly sent to ListenBrainz (through the "inspect listen").
I can also confirm that it isn't currently taken into account when matching tracks. Yet.
Example (Both tracks are properly tagged with MBIDs and have a different track_mbid
linking to two different releases):
Track 1:
Track 2:
I sniffed the webhooks of Plex for fun... Turns out properly MBID-tagged tracks do have MBID UUIDs sent in the webhook... Weird that nobody noticed. Here's an example webhook POST content:
And indeed, Metadata.Guid[0].id contains a beautiful MBID for a track... Which means we can submit it to the API and get actual Album information to ListenBrainz!
Anyways, I've patched a few things to add support for that. I am not that big in the TS territory, so if there's any cleanup to do, I'd advise someone else help me with this!
Cheers.