search

simov / express-admin

MySQL, MariaDB, PostgreSQL, SQLite admin for Node.js
MIT License
1.17k stars 223 forks source link

Fixed AM/PM time without "AM/PM" sign to 24H format #61

Closed zilm13 closed 9 years ago

zilm13 commented 10 years ago

Here is an issue: you use AM/PM 12H format for date but AM/PM is not displayed. Moreover, if you open any entity to edit, datetime field will be filled with time without AM/PM in 12H format, so after save if it's PM it will flush to AM. Here's a small fix: just moved to 24H format.

knownasilya commented 10 years ago

This is a workaround and not really a fix, and I'm sure that's the reason for no activity on this PR.

simov commented 10 years ago

It is a workaround but it certainly fix a present bug (at least partially) I just want to think about this a bit more.

simov commented 9 years ago

Hey, @zilm13

You was totally correct about your fixes. I was just considering the possibility to make the formatting configurable for the end user. Unfortunately there are some inconsistencies between the format that moment.js uses and the one used in the datetimepicker plugin. So I'm dropping this feature for now.

So your fixes are added https://github.com/simov/express-admin/compare/66c3931...532b672dc9 even though I wasn't able to merge your pull request directly, because I moved quite a few files lately.

Besides that I added i18n support for the datetimepicker as well.

:beers: