search

simov / express-admin

MySQL, MariaDB, PostgreSQL, SQLite admin for Node.js
MIT License
1.17k stars 223 forks source link

Try pg.js if pg didn't exist #65

Closed knownasilya closed 9 years ago

knownasilya commented 10 years ago

Allows to use pg without C++ stuff.

knownasilya commented 10 years ago

@simov Would love to get this merged, since it would make it usable for me.

simov commented 10 years ago

OK, I got your point, and this will probably go in, can you fix the indentation though? + your commit contains one more file with file permissions changed

knownasilya commented 10 years ago

@simov fixed, would love if you could deploy this today :smile:

simov commented 10 years ago

This will be published to npm in the next release, which won't be today, since I just released a version today and there are plenty of tasks scheduled for the next release.

In the meantime you can refer to your fork in package.json, or this repo when your code get into master.

knownasilya commented 10 years ago

It was worth a try :wink:

simov commented 10 years ago

I just want to test everything as thoroughly as possible, which certainly gets time. The main place for the automated tests is here but the configuration itself is not fully automated atm, so it's not advisable to spend time trying to run it yet

knownasilya commented 9 years ago

@simov just a friendly reminder that this is still here.

simov commented 9 years ago

I know, if you take a look at my last commits you'll know what I'm up to.

simov commented 9 years ago

Merged. The missing part was this https://github.com/simov/express-admin/commit/834e4cc77e64e84d50a18f7c5d0096885e508a16 that way the error can be propagated back to where it can be handled properly.