search

simov / express-admin

MySQL, MariaDB, PostgreSQL, SQLite admin for Node.js
MIT License
1.17k stars 223 forks source link

Add table filter functionality #73

Closed knownasilya closed 9 years ago

knownasilya commented 9 years ago

Filter for tables, especially useful for lots of tables.

table-filter

simov commented 9 years ago

That's a great idea, and your implementation is slick. However I'm thinking about a filter similar to the one found in the ListView. Also a couple of things are missing from your implementation like responsive UI and internationalization support. I'll probably pull your code and work on that, also note that this project uses tabs for indentation.

knownasilya commented 9 years ago

@simov you should setup an editorconfig file for helping to contribute.

knownasilya commented 9 years ago

@simov I can make those changes if you want, otherwise feel free to do that.

simov commented 9 years ago

Agreed about the editorconfig file. I'll take a look at this one.

simov commented 9 years ago

Hey @knownasilya

Check this out https://github.com/simov/express-admin/commit/27f03f4dc40193fada11d95488ef775bcb01c7e9

It was easier for me to implement it from scratch, that's why there is no merge. I used your idea though, credits in the commit message :beers: