search

simov / grant-profile

User profile middleware for Grant
MIT License
8 stars 8 forks source link

koa middleware should be async #5

Open millette opened 5 years ago

millette commented 5 years ago

See #4 for a proposed fix.

UPDATE: @simov Let me know if you need a better explanation, but currently grant-profile is broken for koa.

simov commented 5 years ago

I will take a look at it during the weekend :+1:

millette commented 5 years ago

Cool, thanks.

I encountered the problem with https://github.com/millette/youp/tree/master/api

Just fill an .env file with valid github keys (see https://github.com/millette/youp/blob/master/api/.env.example), you can use garbage for twitter keys since they're not used (but required because of that .env.example file).

If I use grant-profile from npm I get 404 responses from my other api calls (for instance /api/me) but when I switched to my (temporary) form, I got it working again.

The front-end is provided by https://github.com/millette/youp/tree/master/www if you need it.