simov / grant

OAuth Proxy
MIT License
4.08k stars 257 forks source link

Not working with Shopify when login from shopify admin #247

Closed prabureddy closed 3 years ago

prabureddy commented 3 years ago

Hi @simov. Thanks for the great package.

When a user opens the URL: https://mysite.com/connect/shopify?subdomain={shopname}, it redirects to the shop page to install the Shopify app. And the user is successfully redirected. In this case, the redirected URL is http://mysite/connect/shopify/callback?code=somerandomlettershere&hmac=somerandomlettershere&host=somerandomlettershere&shop={shopname}.myshopify.com&timestamp=123456. This is redirected to http://frontendURL/connect/shopify/redirect?access_token=my_access_token&raw%5Baccess_token%5D=my_access_token&raw%5Bscope%5D=all_scopes. Everything is working up to here.

The problem here is when the user goes to Shopify admin https://{shopname}.myshopify.com/admin/apps, and selects one of theinstalled app to open and he is redirected to http://mysite.com/connect/shopify/callback?hmac=somerandomlettershere&host=somerandomlettershere&session=somerandomlettershere&shop={shopname}.myshopify.com&timestamp=123456.

If we notice here this code param is missing and from here I'm getting redirected to http://frontendURL/connect/shopify/redirect?raw%5Bhmac%5D=somerandomlettershere&raw%5Bhost%5D=somerandomlettershere&raw%5Bnew_design_language%5D=true&raw%5Bsession%5D=somerandomlettershere&raw%5Bshop%5D={shopname}.myshopify.com&raw%5Btimestamp%5D=1622575310

In this above URL instead of getting access_token, I'm getting hmac, shop and other params

This is the issue please help me out.