simov / markdown-viewer

Markdown Viewer / Browser Extension
MIT License
1.02k stars 132 forks source link

Task list not properly detected #152

Closed ShobanChiddarth closed 10 months ago

ShobanChiddarth commented 2 years ago

These are task list previews in Github Screenshot image

Code

These are task list previews in markdown viewer for Chrome (Same code) Screenshot of code image Screenshot of preview image

NOTE: gfm is enabled

simov commented 2 years ago

Hi, what exactly isn't working?

ShobanChiddarth commented 2 years ago

Tasklist (todos)

When I try to put a list in GitHub, I can get the task list without the '•' But when I do the same in Markdown viewer, I get it only with that '•'

Here is the code I used:

- [x] [links](https://www.example.com), **formatting**, and <del>tags</del> supported
- [x] list syntax required (any unordered or ordered list supported)
- [x] this is a complete item
- [ ] this is an incomplete item
simov commented 2 years ago

Got it, I think that's due to the way the underlying compiler parses and renders it. I don't know which implementation should be considered the standard one, but either way this is a question to ask over on the Marked or the Remark repository.

simov commented 10 months ago

Seems to be working in Markdown Viewer v5.2 for all of the supported compilers: marked, remark and markdown-it.

ShobanChiddarth commented 10 months ago

remark is the only thing that works properly

simov commented 10 months ago

I'm pretty sure it worked with markdown-it as well, though note that you have to enable the footnotes option first.

ShobanChiddarth commented 9 months ago

https://imgur.com/a/Q4gxt2D

simov commented 9 months ago

Oh did I say footnotes, I meant tasklists. Have a look at the compiler options for markdown-it here https://github.com/simov/markdown-viewer#compiler-options

ShobanChiddarth commented 9 months ago

markdown-it and remark are working now. marked is the only thing not working.