search

simov / markdown-viewer

Markdown Viewer / Browser Extension
MIT License
1.08k stars 135 forks source link

mermaid - gitGraph is not rendering #180

Closed dhilmathy closed 1 year ago

dhilmathy commented 2 years ago

Mermaid dragram of type gitGraph is not rendering.

Sample

image

Browser used

Extension version

Version 4.0

Output

Extension settings

image

ronaldpetty commented 2 years ago

Confirming it is not rendering in Chrome. Also, if you visit GitHub in Chrome and plugin is enabled and mermaid is used the entire page breaks; sometimes nothing is rendered.

@dhilmathy not sure if this helps you. I got it working by using the Chrome Dev tools. I flipped the state.content.mermaid too true; hit refresh, and it worked. For some reason, I haven't found the settings your showing at all (user error Im sure).

update - sorry for back and forth; I went back and found the UI, flipping the bit in Chrome worked. I am using Version 102.0.5005.115 (Official Build) (x86_64) with latest plugin.

dhilmathy commented 2 years ago

I should've mentioned the browser details in my above ticket itself. I am using Edge (Version 102.0.1245.44). I do not have Chrome and not tested in that.

Note: Updated above description with that information.

simov commented 2 years ago

Maybe the Mermaid version used here is outdated.

When having the extension enabled for all remote origins you have to exclude the github.com origin explicitly because otherwise the extension will interfere with the page as you have observed.

simov commented 1 year ago

Mermaid got updated in Markdown Viewer v5, you can download it from the Chrome Web Store or from the releases section here. The official Edge release will come in the upcoming few weeks so stay tuned for that.