simov / markdown-viewer

Markdown Viewer / Browser Extension
MIT License
1.01k stars 131 forks source link

How do I change the rendered markdown Theme? #221

Closed dattasid closed 2 months ago

dattasid commented 10 months ago

When I click "Extension Settings", I do not see a theme option.

I loaded from the extension from markdown-viewer-v5.1.zip

I only see Origins, Settings, Help . Settings only has: Extension Icon and Content Favicon Color: [Light, Dark], Popup and Options Page Color Mode: [Light, Dark] . Neither of these changes the rendered page css/theme.

I am looking through the source files in options/ folder and I do not see any other option.

What am I missing?

PS: If I can change index.css to change the theme, how do I do it?

simov commented 10 months ago

Simply click on the extension icon with your left mouse button, there is a popup holding those other settings.

dattasid commented 10 months ago

Solved. 😅

Perhaps add 1 line in the README for idiots like me, that clicking on the extension icon in the browser shows this menu, NOT via the Extension Settings link.

dattasid commented 10 months ago

Closed

simov commented 10 months ago

That's a good suggestion. I'm showing that in the introductory screencast as well https://www.youtube.com/watch?v=mlB-SQVq_oU

I'll keep this issue open for now

atomGit commented 10 months ago

this one bit me too :)

possible suggestion to make this more intuitive (rather than adding to readme)...

perhaps display a floating settings icon (3 dots/hamburger icon in upper right) in the rendered md view that opens a pop-up from which all settings can be accessed - this may eliminate the need to register the extension menu item in the Firefox add-ons panel (puzzle icon in the main toolbar)

simov commented 10 months ago

That's a good suggestion too. Personally I have always thought that the extension's popup on left mouse click was the most convenient way to get to its options, but lots of things has changed in the browser UI in the past 10 years so maybe now it is easier to miss the fact that you can left mouse click on it or pin it so that you can access it easier later on.

dattasid commented 10 months ago

Personally I have always thought that the extension's popup on left mouse click was the most convenient way to get to its options

It is still the most convenient place. Just that some people might need a reminder, specially since the theme feels like a Setting and not a Action that is typically on the left click menu.

So a simple statement "Left click the extension icon to change the markdown theme" on the Settings page might be the easiest solution.

A menu directly in the rendered markdown sounds good too, thought probably a bit more work. Suggestion: make it float on the top right as you scroll the page.

stdedos commented 6 months ago

Maybe some button inside the TOC? Or a float on either side of the page? (although I don't really like floats, they remind me chatbots i.e., the scourge). Or just "downright" add them also in settings? (and you can still offer them as a extension-icon-left-click shorthand)

simov commented 2 months ago

Markdown Viewer v5.3 landed with an improved Advanced Options page where you can click on Settings inside the header and get to all of the options available in the popup: Screenshot from 2024-05-04 20-52-40

dattasid commented 2 months ago

TYVM! Closing issue for now, I think UI is clear now.