search

simov / screenshot-capture

Screenshot Capture / Browser Extension
Other
234 stars 81 forks source link

Some website cannot crop or wrong result #2

Open iamkwan opened 7 years ago

iamkwan commented 7 years ago

I found that there are some website cannot trigger the jCrop or wrong result for example: Cannot crop https://chrome.google.com/webstore/category/apps?hl=zh-TW&_feature=website

I dont know how to say this problem http://deepliquid.com/content/Jcrop_Examples.html

also this extension need create element in current page, so all non web page cannot crop anything

And current my extension is use captureVisibleTab to send the base64 image to new tab and set the jCrop with it, so i dont have above problem

simov commented 7 years ago

There are certain sites that are not allowed for Chrome extensions like for example the Chrome Store.

Having the jCrop plugin initialized on the page and using the Screenshot Capture extension would most probably cause issues. I'll add it to my TODO list to think about it, but it's not a high priority one.

What do you mean by non web pages? File URLs, those starting with file:///? Seems to be working on my end.

iamkwan commented 7 years ago

Non web page Eg. Chrome extension page, which enable the development mode On Nov 12, 2016 11:22 PM, "simo" notifications@github.com wrote:

There are certain sites that are not allowed for Chrome extensions like for example the Chrome Store.

Having the jCrop plugin initialized on the page and using the Screenshot Capture extension would most probably cause issues. I'll add it to my TODO list to think about it, but it's not a high priority one.

What do you mean by non web pages? File URLs, those starting with file:///? Seems to be working on my end.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/simov/screenshot-capture/issues/2#issuecomment-260128058, or mute the thread https://github.com/notifications/unsubscribe-auth/AIfvVv2gaTJUIA_SlgxH9KCodkHtfCzLks5q9dm4gaJpZM4KwcGu .

simov commented 7 years ago

These are not allowed too :) I think there is an option to allow it though. Check out this answer on StackOverflow.

iamkwan commented 7 years ago

If you crop in current page it must not allow, But in my case I don't have above problem cuz I capture the screen and send it to new tab assign it in img element and initialize the jCrop

simov commented 7 years ago

That's a good workaround, thanks for sharing it :+1: I'll think about adding it to the extension, but that's not a high priority one too.

pranaymmf commented 3 years ago

Can we show buttons with the J crop preview like i want to add a save and delete button with that preview can we???