search

simov / slugify

Slugifies a string
MIT License
1.5k stars 129 forks source link

Correct danish translation of the letter ø & å #140

Closed jonasholbech closed 2 years ago

jonasholbech commented 2 years ago

Danish has three strange letters, Æ, Ø and Å The translation in charmap.json was wrong for two of them

simov commented 2 years ago

Aren't these handled already in the Danish locale?

jonasholbech commented 2 years ago

Hmm, maybe they are, actually just pulled slugify off the shelf and used it without reading past the initial example. Just noticed that the danish string "æ ø å" came out as "ae o a" (I think it was) so the first was correct the rest wrong. I'm going to close it. Thanks

simov commented 2 years ago

Yes, the issue is that most of these characters were added with their initial transliteration, whatever that was for the first person adding them. That's why we introduced the locales later on so that users can still correct those characters without breaking the library for anyone else already using the default ones.