simp / pupmod-simp-haveged

Manage haveged using Puppet
BSD 2-Clause "Simplified" License
1 stars 11 forks source link

(SIMP-7974) Fix `when: never` rule regex #39

Closed op-ct closed 4 years ago

op-ct commented 4 years ago

The patch corrects the regex operator in the .gitlab-ci.yml YAML anchor &skip_job_when_commit_message_says_to. The previous pipeline had a bug which always skipped spec and acceptance tests (added at the last minute when it was rearranged into semantic anchors, ironically to support when: never)

During testing of this patch, the regex matching for $CI_COMMIT_MESSAGE inside rules:if blocks stopped working (no idea, there are some re parsing quirks in .gitlab-ci.yaml, like https://gitlab.com/gitlab-org/gitlab/-/issues/17680#note_214973340). The regexes have been updated with a workaround and tested for all documented use cases.

CI: SKIP MATRIX SIMP-8010 #close SIMP-7974 #comment Fix when: never regex in .gitlab-ci.yml SIMP-7975 #comment Fix when: never regex in .gitlab-ci.yml