(SIMP-9710) Fix service disable

simp / pupmod-simp-haveged

Manage haveged using Puppet

BSD 2-Clause "Simplified" License

1 stars 11 forks source link

(SIMP-9710) Fix service disable #50

Closed trevor-vaughan closed 3 years ago

trevor-vaughan commented 3 years ago

Fixed
- Mask the service when disabling for rngd compatibility so that it is not restarted on reboot
Changed
- Support puppetlabs/stdlib 7.X
- Updated REFERENCE.md

SIMP-9710 #close

lnemsick-simp commented 3 years ago

FYI the /etc/systemd/system/haveged.service.d directory still hanging around when haveged::package_ensure: absent. Is that expected?

trevor-vaughan commented 3 years ago

@lnemsick-simp It doesn't hurt anything. Trying to go full 'anti-module' generally isn't worth it.

lnemsick-simp commented 3 years ago

Other observations (not specifically about this PR):

The README has class parameters in it. Should reference the REFERENCE.md
I do not see a discussion in the README or init.pp that tells you that the haveged service will not be started (and now masked) if the rngd service is running.

lnemsick-simp commented 3 years ago

Have verified 'mask' option in Puppet service resource now works. Yeah!

trevor-vaughan commented 3 years ago

@lnemsick-simp Could you drop those other items in a ticket for future resolution? Given that this is causing issues in other modules, I don't want to hold it up if possible.