search

simp / pupmod-simp-network

The SIMP network Puppet Module
Other
1 stars 15 forks source link

eth template error #80

Closed roymcmorran closed 1 year ago

roymcmorran commented 1 year ago

In line 167 of templates/eth.erb you specify -timeout but it should be --timeout with two dashes.

Result: Jul 3 17:52:14 hostname network[6337]: Unknown command: -timeout

Also the unless @dhclient_timeout.nil? condition surrounding this can never evaluate to true, because the manifest specifies a default value.

rgardner4012 commented 1 year ago

In line 167 of templates/eth.erb you specify -timeout but it should be --timeout with two dashes.

Result: Jul 3 17:52:14 hostname network[6337]: Unknown command: -timeout

What OS are you seeing this on? I haven't been able to recreate this issue. Generally I would expect a double - like you mention, but in this case it's a single from what I am seeing.

Usage: dhclient [-4|-6] [-SNTPI1dvrxc] [-nw] [-p <port>] [-D LL|LLT]
                [-s server-addr] [-cf config-file] [-lf lease-file]
                [-pf pid-file] [--no-pid] [-e VAR=val]
                [-I <dhcp-client-identifier>] [-B]
                [-H <host-name> | -F <fqdn.fqdn>] [-timeout <timeout>]
                [-V <vendor-class-identifier>]
                [-R <request option list>]
                [-sf script-file] [interface]
roymcmorran commented 1 year ago

Oh interesting, definitely different command syntax. This is Rocky 8.7. Thanks!

# dhclient --help
Internet Systems Consortium DHCP Client 4.3.6
Copyright 2004-2017 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/
Unknown command: --help
Usage: dhclient [-4|-6] [-SNTPRI1dvrxi] [-nw] [-p <port>]
                [-D LL|LLT] [--dad-wait-time seconds]
                [-s server-addr] [-cf config-file]
                [-df duid-file] [-lf lease-file]
                [-pf pid-file] [--no-pid] [-e VAR=val]
                [-sf script-file] [interface]*
                [-C <dhcp-client-identifier>] [-B]
                [-H <host-name> | -F <fqdn.fqdn>] [--timeout <timeout>]
                [-V <vendor-class-identifier>]
                [--address-prefix-len length]
                [--request-options <request option list>]

This version of ISC DHCP is based on the release available
on ftp.isc.org. Features have been added and other changes
have been made to the base software release in order to make
it work better with this distribution.

Please report issues with this software via: 
https://bugs.rockylinux.org/

exiting.
op-ct commented 1 year ago

Looks like there are a few differences in dhclient args―-R does something completely different in EL7 vs EL8!