Closed santisoler closed 1 year ago
@jcapriot I run into some errors today because the environment I had for discretize wasn't running python 3.10, and pre-commit
wasn't throwing some errors when trying to create the virtual environments. Since we are pinning the black and flake8 versions, the python version shouldn't be so important.
If you think otherwise, then I suggest pinning a python version in the environment_test.yml
.
Merging #328 (17c23f0) into main (e14e13e) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 85.16% 85.16%
=======================================
Files 38 38
Lines 11538 11538
=======================================
Hits 9826 9826
Misses 1712 1712
Yeah, this should be fine. I know I was having issues getting pre-commit to run properly on windows on anything less than 3.10
Unpin Python 3.10 in pre-commit configuration and use any available Python 3 interpreter. This fixes issues when the Python version in the environment is not 3.10.