search

simpeg / discretize

Discretization tools for finite volume and inverse problems.
http://discretize.simpeg.xyz/
MIT License
166 stars 34 forks source link

AUTHORS.rst #82

Open lheagy opened 6 years ago

lheagy commented 6 years ago

The author list is out of date. Is this something we want to be maintaining manually? or should we just point to github contributions?

cc @rowanc1

rowanc1 commented 6 years ago

I think keeping this manually updated is good? I quite like what @leouieda has done in fatiando with a PR checklist.

leouieda commented 6 years ago

The checklist is good for new users but it can become a bit of a pain for people making lots of PRs. We sometimes end up just ignoring it, which is not good. Not sure what the best way forward would be. Ideally, a bot that comments on the PR reminding the author but that is a lot of work.

leouieda commented 6 years ago

@lheagy @rowanc1 coming back to this, there is a Github bot called "Welcome Bot" that will post whatever you tell it to when a new user submits a PR, has one merged, or opens a new issue. I've been using it to tell people to submit a new PR adding themselves to the authors file (see the config file). This way the PRs won't have merge conflicts all the time.

What do you think? I could open a PR adding the configurations but I think someone with admin rights needs to enable the app.

lheagy commented 6 years ago

Hi @leouieda: thanks for resurrecting this. I think this would be a very positive addition! We have started sketching out a contributors guide (mostly based off of the fatiando ecosystem 😄) in simpeg/community#3. I think we could get a draft of that in shortly so that there are live links to point to.

Feel free to start a PR and I can enable the app