search

simpeg / geoana

Interactive geoscience (mostly) analytic functions.
MIT License
22 stars 11 forks source link

fix bug found when transmitter not at surface. #21

Closed dccowan closed 3 years ago

dccowan commented 3 years ago

I found a bug in the forward simulation for em1dfm for a layered Earth. The bug happens when the transmitter is not on the surface. I have fixed the code and validated the new code against cyl mesh and octree codes in SimPEG.

image

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (dbde34f) into master (d04c278) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files          20       20           
  Lines         948      948           
=======================================
  Hits          562      562           
  Misses        386      386
Impacted Files Coverage Δ
geoana/em/fdem/layered.py 88.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d04c278...dbde34f. Read the comment docs.