search

simpeg / geoana

Interactive geoscience (mostly) analytic functions.
MIT License
22 stars 9 forks source link

bug fix for halfspace receivers, and example for proper broadcasting #42

Closed jcapriot closed 2 years ago

jcapriot commented 2 years ago

There was a bug introduced in the previous switchover from removing properties in the half-space solution, which is fixed here.

@dccowan this also shows proper numpy broadcasting on the electric-dipole solution, which should be copied into the other dipole solutions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #42 (39fda4b) into main (96d7788) will decrease coverage by 0.25%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   74.85%   74.59%   -0.26%     
==========================================
  Files          25       25              
  Lines        2187     2165      -22     
==========================================
- Hits         1637     1615      -22     
  Misses        550      550
Impacted Files Coverage Δ
geoana/em/fdem/base.py 79.62% <ø> (ø)
geoana/em/fdem/halfspace.py 92.15% <100.00%> (-0.71%) :arrow_down:
geoana/em/fdem/wholespace.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96d7788...39fda4b. Read the comment docs.